Re: [PATCH] svnrdump_sim: start the script with /usr/bin/env python

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 28, 2012, 08:03 UTC
Message-ID: <CAMP44s17Gycr2tWOLYAxMG7-CGP3SpFf7XTWf94qGg3WfVpT-A@mail.gmail.com>
In-Reply-To: <7vy5hmgovt.fsf@alter.siamese.dyndns.org>

On Wed, Nov 28, 2012 at 8:36 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> All the python scripts except contrib/svn-fe/svnrdump_sim.py
>> start with "#!/usr/bin/env python".
>>
>> This patch fix contrib/svn-fe/svnrdump_sim.py to do the same.
>
> I suspect you need a bit more than that.
>
>     $ make git-p4
>     $ diff -u git-p4.py git-p4
>
> shows you how we tell the scripts how to find their interpreters
> (that way, there is no need to rely on the existence of
> /usr/bin/env).

That works if somebody managed to export PYTHON_PATH, which very very often is not the case for me.

./git-p4 zsh: ./git-p4: bad interpreter: /usr/bin/python: no such file or directory

In this case git-p4.py is correct, and git-p4 is not.

Either way, this is for contrib, and we don't have a standard procedure for python scripts there. /usr/bin/env is better than nothing, and in the vast majority of cases, more than enough.

Cheers.

-- 
Felipe Contreras