Re: [PATCH] svnrdump_sim: start the script with /usr/bin/env python
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 28, 2012, 16:57 UTC
- Message-ID
- <7vmwy1hdgx.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAP8UFD08LhywQ9KaNoeG1nORZwtK8MNWqwjfRJPyT2vLkNgs9A@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 24 quoted lines
> On Wed, Nov 28, 2012 at 9:03 AM, Felipe Contreras > <felipe.contreras@gmail.com> wrote: >> On Wed, Nov 28, 2012 at 8:36 AM, Junio C Hamano <gitster@pobox.com> wrote: >>> Christian Couder <chriscool@tuxfamily.org> writes: >>> >>>> All the python scripts except contrib/svn-fe/svnrdump_sim.py >>>> start with "#!/usr/bin/env python". >>>> >>>> This patch fix contrib/svn-fe/svnrdump_sim.py to do the same. >>> >>> I suspect you need a bit more than that. >>> >>> $ make git-p4 >>> $ diff -u git-p4.py git-p4 >>> >>> shows you how we tell the scripts how to find their interpreters >>> (that way, there is no need to rely on the existence of >>> /usr/bin/env). >> >> That works if somebody managed to export PYTHON_PATH, which very very >> often is not the case for me. > > Yeah, and even if PYTHON_PATH is used, in t9020-remote-svn.sh, > svnrdump.py is used as is.
You need a fix for that; didn't I already say "you need a bit more than that"?