Re: [PATCH] svnrdump_sim: start the script with /usr/bin/env python

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 28, 2012, 19:33 UTC
Message-ID: <7v7gp5v7y1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s3YfLrL+74j5DOVVATK8GWEo1qHnmJDW5dLWJRxK_CVLQ@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 7 quoted lines

> On Wed, Nov 28, 2012 at 5:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
>> You need a fix for that; didn't I already say "you need a bit more
>> than that"?
>
> I disagree. Most of the contrib scripts are expected to be used as
> they are.

You are only looking at one of the uses for this script, when there are two.

You are correct that distros may install with whatever tweaks of their own, and to help their tweak process (like the one that specifically notices "/usr/bin/env python" as you wrote), changing the "#!/usr/bin/python" to match others would be a good change.

But that change alone is not sufficient for this one, which is used from t/ script. You cannot treat this one like import-zips and hg-to-git that we do not use in-tree. Somewhere before t9020 uses it, it needs the treatment similar to the rewriting that is done for git-p4.py to git-p4.