git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: add deprecated __git_complete_file ()

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 7, 2013, 19:25 UTC
Message-ID
<CAMP44s0_YkZeC_Xrd1XUo=4=yJDy=8wQKYe34uybhXVqi9bd9Q@mail.gmail.com>
In-Reply-To
<1370632168-25298-1-git-send-email-artagnon@gmail.com>
On Fri, Jun 7, 2013 at 2:09 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> 77c130 (completion: clarify ls-tree, archive, show completion,
> 2013-06-02) removed __git_complete_file () because it had no callers
> left in the file.  However, to avoid breaking user scripts that may
> depend on this, add it back as a deprecated alias.

This is fine by me, but at some point we need to decide how we should prefix the functions that are supposed to be used by external scripts.

Also, maybe we should start adding '# TODO remove in v2.0' so we remember to do that in v2.0.

-- 
Felipe Contreras
Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 2 of 7 in “completion: add deprecated __git_complete_file ()”
  1. completion: add deprecated __git_complete_file ()Ramkumar Ramachandra, Jun 7, 2013
  2. Felipe ContrerasJun 7, 2013
  3. Ramkumar RamachandraJun 7, 2013
  4. Felipe ContrerasJun 7, 2013
  5. SZEDER GáborJun 8, 2013
  6. Junio C HamanoJun 7, 2013
  7. SZEDER GáborJun 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.