Re: [PATCH] completion: add deprecated __git_complete_file ()

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jun 8, 2013, 00:24 UTC
Message-ID: <20130608002452.GE31625@goldbirke>
In-Reply-To: <7vobbhsll3.fsf@alter.siamese.dyndns.org>

On Fri, Jun 07, 2013 at 01:38:16PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Ramkumar Ramachandra <artagnon@gmail.com> writes:
> 
> > 77c130 (completion: clarify ls-tree, archive, show completion,
> > 2013-06-02) removed __git_complete_file () because it had no callers
> > left in the file.  However, to avoid breaking user scripts that may
> > depend on this, add it back as a deprecated alias.
> >
> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> > ---
> >  Based on pu.
> 
> Will queue; thanks.  With this, I think it will be safe to push the
> series in question to 'master'.

Safe? Yes, at least scripts won't break because of the missing function.

However, I still think it would be worth reverting at least the hunks modifying the completion functions of ls-tree and archive. Or better yet, the whole series.