From: Felipe Contreras Date: Fri, 07 Jun 2013 19:25:54 GMT Subject: Re: [PATCH] completion: add deprecated __git_complete_file () Message-ID: In-Reply-To: <1370632168-25298-1-git-send-email-artagnon@gmail.com> On Fri, Jun 7, 2013 at 2:09 PM, Ramkumar Ramachandra wrote: > 77c130 (completion: clarify ls-tree, archive, show completion, > 2013-06-02) removed __git_complete_file () because it had no callers > left in the file. However, to avoid breaking user scripts that may > depend on this, add it back as a deprecated alias. This is fine by me, but at some point we need to decide how we should prefix the functions that are supposed to be used by external scripts. Also, maybe we should start adding '# TODO remove in v2.0' so we remember to do that in v2.0. -- Felipe Contreras