Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?

From: Noam Postavsky <npostavs@users.sourceforge.net>
Date: Oct 30, 2015, 00:43 UTC
Message-ID: <CAM-tV-_dc_YEE0Dh2T=8+_DcBiq_rvynOw2cFi+8QizkeGTusw@mail.gmail.com>
In-Reply-To: <20151030001000.GA2123@sigill.intra.peff.net>

On Thu, Oct 29, 2015 at 8:10 PM, Jeff King <peff@peff.net> wrote:

Show 10 quoted lines

> On Tue, Oct 27, 2015 at 11:46:20PM -0400, Noam Postavsky wrote:
>> Perhaps we could express the auto-spawn more explicitly, something
>> like "git config credential.pre-helper start-cache-daemon". A way to
>> run a command before the credential helpers start would be useful to
>> our magit workaround for this issue (currently we start the daemon
>> before "push", "fetch", and "pull", but it won't work with user
>> aliases that run those commands).
>
> I'm not clear on when the pre-helper would be run. Git runs the helper
> when it needs a credential. What git command would start it?

I was just thinking in terms of our current workaround, it would have been helpful to be able to run a command just before the helpers are run. Or in other words, as the first helper. (doing "git -c credential.helper=foo" puts foo as the last helper).

> I guess the most elegant thing would be to add an "init" command to the
> helper interface. So magit would run:
>
>   git credential init

Although, we could use something like that too, as we're currently checking the helpers configured and then running git credential-cache--daemon directly.

> I dunno. It almost seems like adding a credentialcache.ignoreHUP option
> would be less hacky. :)

The pre-helper thing is probably the best way to make the current hacks less hacky, but maybe not so great for actually fixing the problem and getting rid of the need for said hacks. :)

> Mostly, I think, because there was a lot of support load in teaching
> people to set up ssh. But I guess a lot of those people are on
> non-Linux platforms.

Hmm, the pre-helper thing would also help for the hack I wrote getting ssh-agent to autostart and work from Emacs on Windows (ssh-agent on Windows is a total PITA).