Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?
- From
Noam Postavsky <npostavs@users.sourceforge.net>
- Date
- Oct 19, 2015, 00:51 UTC
- Message-ID
- <CAM-tV-8BQPhGXe0nNFHEWPV_SnoOiCd9OxSiSYk22f86F4KtFA@mail.gmail.com>
- In-Reply-To
- <xmqqfv18awj4.fsf@gitster.mtv.corp.google.com>
On Sun, Oct 18, 2015 at 1:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> I cannot speak for the person who was primarily responsible for > designing this behaviour, but I happen to agree with the current > behaviour in the situation where it was designed to be used. Upon > the first use in your session, the "daemon" is auto-spawned, you can > keep talking with that same instance during your session, and you do > not have to do anything special to shut it down when you log out.
Oh, hmm this does makes sense. Now that I think of the log out case, I think ignoring the SIGHUP would be the wrong thing for us too.
> Isn't that what happens here?
I think our problem is that when Emacs creates the "git push" process with a pty[1], it somehow puts that process in its own new session, so when "git push" finishes it takes the daemon down with it. But seeing it like this, it seems clear that the problem is from the Emacs side.
[1]: and using pipes instead of a pty doesn't allow entering the password: https://github.com/magit/magit/issues/2309#issuecomment-147101903