Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?

From: Jeff King <peff@peff.net>
Date: Dec 4, 2015, 23:25 UTC
Message-ID: <20151204232546.GC15064@sigill.intra.peff.net>
In-Reply-To: <xmqqlh9arnbz.fsf@gitster.mtv.corp.google.com>

On Fri, Dec 04, 2015 at 12:05:52PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> > This probably _does_ trigger setup_git_env() when it was not otherwise
> > called, and it will back to looking at ".git/config" for the repo-level
> > config. That may fail to find the file if we are in a bare repository,
> > or a subdirectory of the working tree. IOW, I suspect this:
> >
> >   git init --bare foo.git
> >   cd foo.git
> >   git config credential.helper cache
> >   git config credentialcache.ignoreSIGHUP true ;# goes into local config
> >   git fetch https://example.com/foo.git
> >
> > may fail to respect the ignoreSIGHUP option.
> >
> > I guess the solution would be to setup_git_director_gently() in the
> > daemon process.
> 
> So I guess I did notice the right breakage ;-)
> 
> At least, this won't be a regression but "a new feature initially
> shipped with a broken corner case", so a follow-up fix is welcome,
> but not a big deal that I've already merged it to 'master'.

Yeah, agreed on all counts. Thanks for noticing.

I suspect in practice is a pretty rare corner case, but I will leave it to those who are interested in the feature to do the fixup.

-Peff