Re: [PATCH v3 1/3] t1517: fixup for ua/t1517-short-help-tests
On Sun, Aug 3, 2025 at 12:41 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 32 quoted lines
>
> "D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
>
> > - fix instaweb test prereqs
> >
> > Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> > ---
> > t/t1517-outside-repo.sh | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
> > index 8a417af47a..3dc602872a 100755
> > --- a/t/t1517-outside-repo.sh
> > +++ b/t/t1517-outside-repo.sh
> > @@ -123,7 +123,13 @@
> > *)
> > expect_outcome=expect_success ;;
> > esac
> > - test_$expect_outcome "'git $cmd -h' outside a repository" '
> > + case "$cmd" in
> > + instaweb)
> > + prereq=PERL ;;
> > + *)
> > + prereq= ;;
> > + esac
> > + test_$expect_outcome $prereq "'git $cmd -h' outside a repository" '
> > test_expect_code 129 nongit git $cmd -h >usage &&
> > test_grep "[Uu]sage: git $cmd " usage
> > '
>
> Ideally this would want to be squashed (or moved) into the base
> topic. Can you two coordinate among yourselves?
Agreed, and happy to—just not sure what that looks like here. Advice welcome :)