Re: [RFC PATCH 0/2] Support --verbose in git history
- From
D. Ben Knoble <ben.knoble@gmail.com>
- Date
- Nov 9, 2026, 12:43 UTC
- Message-ID
- <CALnO6CCfKsd=w1kVvbJ83WtJPbsH8hGcfZUUTE9eGqWOZeA=AA@mail.gmail.com>
- In-Reply-To
- <CAOLa=ZT_U+gDjdLYkbtqRjUxwHA6q6+Uk4ssznyHgn09xcFqpw@mail.gmail.com>
On Mon, Nov 9, 2026 at 7:06 AM Karthik Nayak <karthik.188@gmail.com> wrote:
Show 22 quoted lines
> > Phillip Wood <phillip.wood123@gmail.com> writes: > > > On 07/11/2026 19:49, D. Ben Knoble wrote: > >> On Sat, Nov 7, 2026 at 2:36 PM Jelle van der Waa <jelle@vdwaa.nl> wrote: > >>> > >> > >> Anyway, my point is, there's a lot of possible meanings for "verbose", > > > > That's a good point > > > >> so maybe we could use "--commit-verbose" (blech), "--diff-in-editor", > >> or some other thing that smarter folks than I will come up with which > >> clearly signals what we're about? > > > > Off the top of my head --show-diff, though I'm not sure that's any > > better than your suggestions > > > > My preference would be to make this (current patch) default behavior and > not even have an option. I don't see a disadvantage of having the diff > always being shown and it definitely is a better default to have.
When the diff is extremely long, or if the user has other means of obtaining it and wants the editor to open quickly, it may not be desired. So I'd prefer to still have it optional, personally.
-- D. Ben Knoble