Re: [RFC PATCH 0/2] Support --verbose in git history
- From
- Jelle van der Waa <jelle@vdwaa.nl>
- Date
- Nov 16, 2026, 19:23 UTC
- Message-ID
- <734e2ca8-e01a-4204-9cd3-a09a8d097f64@vdwaa.nl>
- In-Reply-To
- <53CA2747-58F6-4A7C-81EC-33EABF0000FC@gmail.com>
On 11/10/26 18:15, Ben Knoble wrote:
Show 35 quoted lines
> > >> Le 10 nov. 2026 à 08:13, Karthik Nayak <karthik.188@gmail.com> a écrit : >> >> Phillip Wood <phillip.wood123@gmail.com> writes: >> >>>> On 09/11/2026 12:43, D. Ben Knoble wrote: >>>> On Mon, Nov 9, 2026 at 7:06 AM Karthik Nayak <karthik.188@gmail.com> wrote: >>>>> >>>>> My preference would be to make this (current patch) default behavior and >>>>> not even have an option. I don't see a disadvantage of having the diff >>>>> always being shown and it definitely is a better default to have. >>>> >>>> When the diff is extremely long, or if the user has other means of >>>> obtaining it and wants the editor to open quickly, it may not be >>>> desired. So I'd prefer to still have it optional, personally. >>> >>> Another case where we might not want the diff is scripted editing as it >>> is much easier if the script does not have to worry about the diff >>> getting in the way of its edits. Personally I'd be happy to see this on >>> by default - the history command is marked as experimental so if having >>> it on by default rather than following "commit.verbose" proves to be >>> problematic we can always change it in the future. If we were staring >>> again I'd also make "commit.verbose" on by default as well so maybe I'm >>> biased. >>> >>> Thanks >>> >>> Phillip >> >> I'm on board with this suggestion. Plus, I see 'git history' to be more >> user facing and it's always nicer to have better defaults for users. >> Showing diffs and verbose information seems to be inline with that. We >> could add an option to disable such output for scripts (but that can be >> done later as you suggested). >> <signature.asc> > > I can live with opt-out as long as I can turn it off via config.
It seems most of the replies agree that "verbose" should be the default with a means to opt-out. git history split, reword and fixup would turn this on (as drop does not have an way to interact with a commit message).
I'll spin up a new patch which will drop the --verbose option and make "verbose" follow commit.verbose and make it the default for git history.
Thanks for all the feedback,
Jelle van der Waa