git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 1/2] history: drop redundant strbuf_stripspace()

From
JWJelle van der Waa <jelle@vdwaa.nl>
Date
Nov 7, 2026, 19:30 UTC
Message-ID
<20261107193020.583215-2-jelle@vdwaa.nl>
In-Reply-To
<20261107193020.583215-1-jelle@vdwaa.nl>

cleanup_message() with COMMIT_MSG_CLEANUP_ALL already calls strbuf_stripspace() with the same arguments.

Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
---
 builtin/history.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/builtin/history.c b/builtin/history.c
index 43ba76f5a1..cdb0d30784 100644
--- a/builtin/history.c
+++ b/builtin/history.c
@@ -94,7 +94,6 @@ static int fill_commit_message(struct repository *repo,
 		fprintf(stderr, _("Aborting commit as launching the editor failed.\n"));
 		return -1;
 	}
-	strbuf_stripspace(out, comment_line_str);
 
 	cleanup_message(out, COMMIT_MSG_CLEANUP_ALL, 0);
 
-- 
2.56.0
Previous: Jelle van der WaaNext: Jelle van der Waa
Message 2 of 19 in “Support --verbose in git history”
  1. 0/2 Support --verbose in git historyJelle van der Waa, Nov 7, 2026
  2. 1/2 history: drop redundant strbuf_stripspace()Jelle van der Waa, Nov 7, 2026
  3. 2/2 history: add --verbose option for rewordJelle van der Waa, Nov 7, 2026
  4. Phillip WoodNov 9, 2026
  5. D. Ben KnobleNov 7, 2026
  6. Phillip WoodNov 9, 2026
  7. Karthik NayakNov 9, 2026
  8. D. Ben KnobleNov 9, 2026
  9. Phillip WoodNov 9, 2026
  10. Karthik NayakNov 10, 2026
  11. Ben KnobleNov 10, 2026
  12. Patrick SteinhardtNov 11, 2026
  13. Phillip WoodNov 11, 2026
  14. Patrick SteinhardtNov 11, 2026
  15. Ben KnobleNov 11, 2026
  16. Patrick SteinhardtNov 11, 2026
  17. Jelle van der WaaNov 16, 2026
  18. Ben KnobleNov 17, 2026
  19. Junio C HamanoNov 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.