git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4002: fix "diff can read from stdin" syntax

From
D. Ben Knoble <ben.knoble+github@gmail.com>
Date
Jul 14, 2023, 14:53 UTC
Message-ID
<CALnO6CCOWvYLkGRJOSV5saK3g3s0+RD-aEopF6gcX3qfmU5=UQ@mail.gmail.com>
In-Reply-To
<279beaea-d332-0d88-3cd0-b935ef6bc5eb@web.de>
On Fri, Jul 14, 2023 at 10:44 AM René Scharfe <l.s.r@web.de> wrote:
Show 5 quoted lines
>
> Good find!  Introduced by 9cfcbcc095 (t4002-diff-basic: modernize test
> format, 2023-05-18).  Perhaps an automatic formatter would have avoided
> it?  E.g. some sed(1) scripting, or shfmt (https://github.com/mvdan/sh)?
> (Just discovered shfmt, never used it.)

I'm doubtful: it would have to know things about the test_* commands. (I would expect context-blind formatters to leave it alone, as it is a perfectly correct way to spell a command with spaces in the name, though who would do such a thing, I don't know.)

Previous: René ScharfeNext: John Cai
Message 3 of 5 in “t4002: fix "diff can read from stdin" syntax”
  1. t4002: fix "diff can read from stdin" syntaxD. Ben Knoble via GitGitGadget, Jul 14, 2023
  2. René ScharfeJul 14, 2023
  3. D. Ben KnobleJul 14, 2023
  4. John CaiJul 14, 2023
  5. Junio C HamanoJul 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.