git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4002: fix "diff can read from stdin" syntax

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 14, 2023, 16:52 UTC
Message-ID
<xmqqzg3yph9r.fsf@gitster.g>
In-Reply-To
<pull.1545.git.git.1689341410476.gitgitgadget@gmail.com>
"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 17 quoted lines
> From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
>
> I noticed this test was producing output like
>
> ```
> t4002-diff-basic.sh: test_expect_successdiff can read from stdin: not found
> ```
>
> which is rather odd. Investigation shows an error of shell syntax:
> foo'abc' is the same as fooabc to the shell. Perhaps obviously, this is
> not a valid command for the test.
>
> I am surprised this doesn't count as an error in the test, but that
> accounts for it going unnoticed.
>
> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
> ---
Nicely spotted.  Thanks.
Will queue.
Previous: John Cai
Message 5 of 5 in “t4002: fix "diff can read from stdin" syntax”
  1. t4002: fix "diff can read from stdin" syntaxD. Ben Knoble via GitGitGadget, Jul 14, 2023
  2. René ScharfeJul 14, 2023
  3. D. Ben KnobleJul 14, 2023
  4. John CaiJul 14, 2023
  5. Junio C HamanoJul 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.