From: D. Ben Knoble <ben.knoble+github@gmail.com>
Date: Fri, 14 Jul 2023 14:53:48 GMT
Subject: Re: [PATCH] t4002: fix "diff can read from stdin" syntax
Message-ID: <CALnO6CCOWvYLkGRJOSV5saK3g3s0+RD-aEopF6gcX3qfmU5=UQ@mail.gmail.com>
In-Reply-To: <279beaea-d332-0d88-3cd0-b935ef6bc5eb@web.de>

On Fri, Jul 14, 2023 at 10:44 AM René Scharfe <l.s.r@web.de> wrote:
>
> Good find!  Introduced by 9cfcbcc095 (t4002-diff-basic: modernize test
> format, 2023-05-18).  Perhaps an automatic formatter would have avoided
> it?  E.g. some sed(1) scripting, or shfmt (https://github.com/mvdan/sh)?
> (Just discovered shfmt, never used it.)

I'm doubtful: it would have to know things about the test_* commands.
(I would expect context-blind formatters to leave it alone, as it is a
perfectly correct way to spell a command with spaces in the name,
though who would do such a thing, I don't know.)