git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Fix invalid revision error messages for 1.8.3

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 21, 2013, 17:50 UTC
Message-ID
<CALkWK0nXbncV4bjHLSQCu21w36vQP5E9irNhBbyXoEZ4-oqfcQ@mail.gmail.com>
In-Reply-To
<7vy5b8p9wm.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Fixes to something that are broken the same way between 'master' and
> older release versions are the same as enhancements (which you can
> view as "fix to lack of feature").  They are not regression fixes
> and not for 1.8.3 at this point in the cycle, deep into -rc.

If we view them as enhancements, well and good. Let's polish them until we're really happy with them: they're written with the "minimal, but correct" philosophy, because the -rc3 window is too small for a review.

Just to share opinion, they looked like "bugs" to me, because it's not about "improving" the error messages; it's about correcting a defect. The author could not have possibly intended two "error: " lines in the first one, or an empty string in the second one. At some point in the past, the behavior must have been different (a "feature" must have introduced these problems: like implicit HEAD for @{<N>}): the "regression" was introduced in the version after that. So, is it because that version was too long ago that we don't consider it a regression (do we backport fixes)?

Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 19 in “Fix invalid revision error messages for 1.8.3”
  1. 0/2 Fix invalid revision error messages for 1.8.3Ramkumar Ramachandra, May 21, 2013
  2. 1/2 sha1_name: fix error message for @{u}Ramkumar Ramachandra, May 21, 2013
  3. Junio C HamanoMay 21, 2013
  4. Ramkumar RamachandraMay 21, 2013
  5. Junio C HamanoMay 21, 2013
  6. Ramkumar RamachandraMay 21, 2013
  7. Junio C HamanoMay 21, 2013
  8. Ramkumar RamachandraMay 21, 2013
  9. Junio C HamanoMay 21, 2013
  10. Ramkumar RamachandraMay 21, 2013
  11. Junio C HamanoMay 21, 2013
  12. 2/2 sha1_name: fix error message for @{<N>}, @{<date>}Ramkumar Ramachandra, May 21, 2013
  13. Junio C HamanoMay 21, 2013
  14. Kevin BraceyMay 21, 2013
  15. Ramkumar RamachandraMay 21, 2013
  16. Junio C HamanoMay 21, 2013
  17. Ramkumar RamachandraMay 21, 2013
  18. Junio C HamanoMay 21, 2013
  19. Ramkumar RamachandraMay 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.