Re: [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>}
- From
Kevin Bracey <kevin@bracey.fi>
- Date
- May 21, 2013, 17:38 UTC
- Message-ID
- <519BB104.9060802@bracey.fi>
- In-Reply-To
- <7vppwkp961.fsf@alter.siamese.dyndns.org>
On 21/05/2013 19:52, Junio C Hamano wrote:
Show 19 quoted lines
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> The empty string '' looks ugly and inconsistent with the output of
>> <branch>@{<N>}. Replace it with the string 'current branch'.
> Wouldn't that be '*the* current branch'?
>
> More importantly, doesn't "real_ref" have the name of the branch?
>
> Suppose the user said "git show @{10000}" instead of "git show
> master@{10000}" while on 'master'.
>
> It could be argued that it may look nicer to say "your current
> branch does not have enough update history" instead of saying
> "master does not..." (i.e. different input to ask for the same
> thing, different output depending on the way the user asked). It
> also could be argued that they should produce the same diagnosis
> that is more informative.
>
> I am slightly leaning toward the latter.That would also avoid the complaint I was about to make that putting 'current branch' in scare quotes would be annoying.
Kevin