git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>}

From
Kevin Bracey <kevin@bracey.fi>
Date
May 21, 2013, 17:38 UTC
Message-ID
<519BB104.9060802@bracey.fi>
In-Reply-To
<7vppwkp961.fsf@alter.siamese.dyndns.org>
On 21/05/2013 19:52, Junio C Hamano wrote:
Show 19 quoted lines
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> The empty string '' looks ugly and inconsistent with the output of
>> <branch>@{<N>}.  Replace it with the string 'current branch'.
> Wouldn't that be '*the* current branch'?
>
> More importantly, doesn't "real_ref" have the name of the branch?
>
> Suppose the user said "git show @{10000}" instead of "git show
> master@{10000}" while on 'master'.
>
> It could be argued that it may look nicer to say "your current
> branch does not have enough update history" instead of saying
> "master does not..." (i.e. different input to ask for the same
> thing, different output depending on the way the user asked).  It
> also could be argued that they should produce the same diagnosis
> that is more informative.
>
> I am slightly leaning toward the latter.

That would also avoid the complaint I was about to make that putting 'current branch' in scare quotes would be annoying.

Kevin
Previous: Junio C HamanoNext: Ramkumar Ramachandra
Message 14 of 19 in “Fix invalid revision error messages for 1.8.3”
  1. 0/2 Fix invalid revision error messages for 1.8.3Ramkumar Ramachandra, May 21, 2013
  2. 1/2 sha1_name: fix error message for @{u}Ramkumar Ramachandra, May 21, 2013
  3. Junio C HamanoMay 21, 2013
  4. Ramkumar RamachandraMay 21, 2013
  5. Junio C HamanoMay 21, 2013
  6. Ramkumar RamachandraMay 21, 2013
  7. Junio C HamanoMay 21, 2013
  8. Ramkumar RamachandraMay 21, 2013
  9. Junio C HamanoMay 21, 2013
  10. Ramkumar RamachandraMay 21, 2013
  11. Junio C HamanoMay 21, 2013
  12. 2/2 sha1_name: fix error message for @{<N>}, @{<date>}Ramkumar Ramachandra, May 21, 2013
  13. Junio C HamanoMay 21, 2013
  14. Kevin BraceyMay 21, 2013
  15. Ramkumar RamachandraMay 21, 2013
  16. Junio C HamanoMay 21, 2013
  17. Ramkumar RamachandraMay 21, 2013
  18. Junio C HamanoMay 21, 2013
  19. Ramkumar RamachandraMay 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.