Re: [PATCH 1/2] sha1_name: fix error message for @{u}

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 21, 2013, 20:14 UTC
Message-ID: <CALkWK0kVAG4Gg3mgZv+0pXJocwDzZYS3gwVjxPy9cmBEkB2sFg@mail.gmail.com>
In-Reply-To: <7vtxlwm6z4.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 13 quoted lines

>> interpret_branch_name -> interpret_branch_name (recursion)
>>                       -> get_sha1_basic -> get_sha1 [context] (end-user data)
>>                       -> substitute_branch_name -> dwim (end-user data)
>>                     -> strbuf_branchname (callers pass a branch name; no @{u})
>>                     -> revision.c:add_pending_object [with_mode] (end-user data)
>>
>> [die_]verify_filename -> builtin/rev-parse.c (end-user)
>>                     -> builtin/reset.c (end-user)
>>                     -> builtin/grep.c:cmd_grep (end-user)
>>                     -> revision.c:setup_revisions (end-user data)
>
> It seems that you are digging in the wrong direction?  I was worried
> about the callers of interpret_branch_name().

Um, aren't interpret_branch_name, get_sha1_basic, substitute_branch_name, strbuf_branchname, and add_pending_object the five callers of interpret_branch_name? I've tried to show how they are called with either end-user data or programmatic data without a "@{u}". What am I missing?