Re: [PATCH 3/5] sequencer: sequencer state is useless without todo
Hi,
Jonathan Nieder wrote:
Show 10 quoted lines
> Ramkumar Ramachandra wrote:
> [...]
> The usual commit-message debugging strategy applies here: imagine you
> are a BIOS clone manufacturer, and for legal reasons you are not
> allowed to read this part of the git implementation embedded in the
> standard BIOS. However, you are allowed to read the commit message,
> and if that message is clear enough, it will explain the purpose and
> behavior of that code and you will be able to implement a compatible
> implementation addressing the same problem without scratching your
> head too much.
Ah, it helps to think about commit messages like this. Thanks.
Show 10 quoted lines
>> --- a/sequencer.c
>> +++ b/sequencer.c
>> @@ -654,11 +654,15 @@ static void walk_revs_populate_todo(struct replay_insn_list **todo_list,
>>
>> static int create_seq_dir(void)
>> {
>> + const char *todo_file = git_path(SEQ_TODO_FILE);
>> const char *seq_dir = git_path(SEQ_DIR);
>
> Scary idiom.What's scary about it?
-- Ram
Ramkumar Ramachandra <artagnon@gmail.com>