Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 13, 2013, 07:40 UTC
Message-ID: <CALkWK0m0dT-sX=nu5jaDj=y1oOSo0cRKQ=2K_S-yepnsm8ny7A@mail.gmail.com>
In-Reply-To: <7v61ynsci8.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> It is like asking why typeset a space after a sentence a tad wider
> than a space after each word:

Not at all.  The prompt has nothing to do with sentences.

> grouping related things together, and
> separating groups of different kind apart, to make it more readable.

You could argue that the colors are not very well thought-out (branch-name has the same color as +), but I really don't see the problem otherwise. How is this more readable:

    artagnon|master *=:~/src/git$

than:

    artagnon|master*=:~/src/git$

(where master is green, * is red, and = is white)?

Looking at what we've done so far, I would argue that we're not thinking about the usability of the prompt enough: it currently screams I AM DOING REBASE-i! (and similarly for other operations in progress). I intend to fix these things in future patches.

Thanks.