Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

From: SZEDER Gábor <szeder@ira.uka.de>
Date: May 13, 2013, 09:17 UTC
Message-ID: <20130513091718.GA21636@goldbirke>
In-Reply-To: <CALkWK0m0dT-sX=nu5jaDj=y1oOSo0cRKQ=2K_S-yepnsm8ny7A@mail.gmail.com>

On Mon, May 13, 2013 at 01:10:26PM +0530, Ramkumar Ramachandra wrote:

Show 15 quoted lines

> Junio C Hamano wrote:
> > grouping related things together, and
> > separating groups of different kind apart, to make it more readable.
> 
> You could argue that the colors are not very well thought-out
> (branch-name has the same color as +), but I really don't see the
> problem otherwise.  How is this more readable:
> 
>     artagnon|master *=:~/src/git$
> 
> than:
> 
>     artagnon|master*=:~/src/git$
> 
> (where master is green, * is red, and = is white)?

IMHO that's just ugly ;)

Don't forget that others might use a different prompt format and using colors in the prompt is optional. With the default prompt format and without colors I find that that space definitely helps readability.

Gábor