git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 11, 2013, 16:25 UTC
Message-ID
<1368289513-8700-2-git-send-email-artagnon@gmail.com>
In-Reply-To
<1368289513-8700-1-git-send-email-artagnon@gmail.com>

Nobody has branch names that end with + or *. Then why put a space after the branch name and before [*|+][=|<|>] in the prompt string?

Before this, your prompt might have looked like:
    artagnon|master *=:~/src/git$
Now, it will look like:
    artagnon|master*=:~/src/git$
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 contrib/completion/git-prompt.sh | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh
index eaf5c36..08c9b22 100644
--- a/contrib/completion/git-prompt.sh
+++ b/contrib/completion/git-prompt.sh
@@ -383,9 +383,6 @@ __git_ps1 ()
 				# is necessary to prevent wrapping issues!
 				gitstring="\[$branch_color\]$branchstring\[$c_clear\]"
 
-				if [ -n "$w$i$s$u$r$p" ]; then
-					gitstring="$gitstring "
-				fi
 				if [ "$w" = "*" ]; then
 					gitstring="$gitstring\[$bad_color\]$w"
 				fi
@@ -400,13 +397,13 @@ __git_ps1 ()
 				fi
 				gitstring="$gitstring\[$c_clear\]$r$p"
 			else
-				gitstring="$c${b##refs/heads/}${f:+ $f}$r$p"
+				gitstring="$c${b##refs/heads/}${f:+$f}$r$p"
 			fi
 			gitstring=$(printf -- "$printf_format" "$gitstring")
 			PS1="$ps1pc_start$gitstring$ps1pc_end"
 		else
 			# NO color option unless in PROMPT_COMMAND mode
-			printf -- "$printf_format" "$c${b##refs/heads/}${f:+ $f}$r$p"
+			printf -- "$printf_format" "$c${b##refs/heads/}${f:+$f}$r$p"
 		fi
 	fi
 }
-- 
1.8.3.rc1.52.g4537cf1
Previous: Ramkumar RamachandraNext: Junio C Hamano
Message 2 of 16 in “Colored prompt for zsh”
  1. 0/2 Colored prompt for zshRamkumar Ramachandra, May 11, 2013
  2. 1/2 git-prompt.sh: strip unnecessary space in prompt stringRamkumar Ramachandra, May 11, 2013
  3. Junio C HamanoMay 13, 2013
  4. Ramkumar RamachandraMay 13, 2013
  5. SZEDER GáborMay 13, 2013
  6. Ramkumar RamachandraMay 13, 2013
  7. SZEDER GáborMay 13, 2013
  8. SZEDER GáborMay 13, 2013
  9. Junio C HamanoMay 13, 2013
  10. Ramkumar RamachandraMay 13, 2013
  11. 2/2 git-prompt.zsh: introduce thin ZSH wrapperRamkumar Ramachandra, May 11, 2013
  12. Felipe ContrerasMay 11, 2013
  13. git-prompt.sh: colorize ZSH promptRamkumar Ramachandra, May 11, 2013
  14. Felipe ContrerasMay 11, 2013
  15. Ramkumar RamachandraMay 11, 2013
  16. Felipe ContrerasMay 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.