Re: [PATCH 17/18] revert: Introduce --continue to continue the operation

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Aug 2, 2011, 04:41 UTC
Message-ID: <CALkWK0kvAaKdKT2Syzr2WdbHVShci+M-vHCJufWY0LDu5=ZGqA@mail.gmail.com>
In-Reply-To: <201108020451.36617.chriscool@tuxfamily.org>

Hi Christian,

Christian Couder writes:

> On Tuesday 02 August 2011 04:47:01 Christian Couder wrote:
>> We can simplify this loop using strchrnul() like this:

[...]

Show 9 quoted lines

>        for (i = 1; *p; i++) {
>                struct commit *commit = parse_insn_line(p, opts);
>                if (!commit)
>                        return error(_("Could not parse line %d."), i);
>                next = commit_list_append(commit, next);
>                p = strchrnul(p, '\n');
>                if (*p)
>                        p++;
>        }

Thanks for the valuable review. I would have preferred to receive it earlier in the development cycle than later- although I've queued this along with other similar changes (error reporting/ stylistic changes; not urgent), I'm not in favor of holding up the series.

Thank you.

-- Ram