Re: [PATCH 17/18] revert: Introduce --continue to continue the operation
- From
Christian Couder <chriscool@tuxfamily.org>
- Date
- Aug 2, 2011, 02:51 UTC
- Message-ID
- <201108020451.36617.chriscool@tuxfamily.org>
- In-Reply-To
- <201108020447.02545.chriscool@tuxfamily.org>
On Tuesday 02 August 2011 04:47:01 Christian Couder wrote:
Show 9 quoted lines
> We can simplify this loop using strchrnul() like this:
>
> for (i = 1; *p; i++) {
> struct commit *commit = parse_insn_line(p, opts);
> if (!commit)
> return error(_("Could not parse line %d."), i);
> next = commit_list_append(commit, next);
> p = strchrnul(p, '\n');
> }Ooops, sorry I mean like this:
for (i = 1; *p; i++) {
struct commit *commit = parse_insn_line(p, opts);
if (!commit)
return error(_("Could not parse line %d."), i);
next = commit_list_append(commit, next);
p = strchrnul(p, '\n');
if (*p)
p++;
}Thanks, Christian.