Re: [PATCH 17/18] revert: Introduce --continue to continue the operation

From: Christian Couder <chriscool@tuxfamily.org>
Date: Aug 2, 2011, 02:47 UTC
Message-ID: <201108020447.02545.chriscool@tuxfamily.org>
In-Reply-To: <201108020436.42148.chriscool@tuxfamily.org>

On Tuesday 02 August 2011 04:36:41 Christian Couder wrote:

Show 18 quoted lines

>
> static int parse_insn_buffer(char *buffer,
> 			     struct commit_list **todo_list,
> 			     struct replay_opts *opts)
> {
> 	struct commit_list **next = todo_list;
> 	char *p = buffer;
> 	int i;
> 
> 	for (i = 1; p && *p; i++) {
> 		struct commit *commit = parse_insn_line(p, opts);
> 		if (!commit)
> 			return error(_("Could not parse line %d."), i);
> 		next = commit_list_append(commit, next);
> 		p = strchr(p, '\n');
> 		if (p)
> 			p++;
> 	}

We can simplify this loop using strchrnul() like this:

 	for (i = 1; *p; i++) {
 		struct commit *commit = parse_insn_line(p, opts);
 		if (!commit)
 			return error(_("Could not parse line %d."), i);
 		next = commit_list_append(commit, next);
 		p = strchrnul(p, '\n');
 	}

Thanks, Christian.