Re: [PATCH v3] gc: reject if another gc is running, unless --force is given
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Aug 5, 2013, 18:37 UTC
- Message-ID
- <CALkWK0kZ=5TguAh9krAzFNuF0_sTRxcQKuZMnuQG7FQU0dJe=g@mail.gmail.com>
- In-Reply-To
- <7vsiyoj932.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> [...]
The other comments mostly make sense.
> After reading what the whole function does, I think the purpose of > this function is to take gc-lock (with optionally force). Perhaps a > name along the lines of "lock_gc", "gc_lock", "lock_repo_for_gc", > would be more appropriate.
The whole point of this exercise is to _not_ lock up the repo during gc, so I can do minimal commit/ worktree/ ref update operations when it's running. I can't expect the reflog to work, so complex history-rewriting operations should be avoided; that's about it, I think.