Re: [PATCH v4] gc: reject if another gc is running, unless --force is given

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 9, 2013, 12:52 UTC
Message-ID: <CACsJy8DRRLkyZid_OPSvRkvKfnd62TnLBnaueim9GrXUikPGuw@mail.gmail.com>
In-Reply-To: <7vk3jw9hlm.fsf@alter.siamese.dyndns.org>

On Fri, Aug 9, 2013 at 1:12 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> When we see a recent lockfile created by a "gc" running elsewhere,
> we do not set "should_exit".  Is that a good thing?  I am wondering
> if the last two lines should be:
>
> -       !strcmp(locking_host, my_host) &&
> -       !kill(pid, 0);
> +       (strcmp(locking_host, my_host) || !kill(pid, 0));
>
> instead.

Yes I think it should (we still have the 12-hour check to override stale locks anyway). Should I send another patch or you do it yourself (seeing that you have this chunk pasted here, you might have it saved somewhere already)

-- 
Duy