Re: [PATCH v2 0/3] Towards a useable git-branch
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 4, 2013, 12:52 UTC
- Message-ID
- <CALkWK0kGrCDhDFL5THBTTVARTnfY2xucbJaGJGKj8OYv3Q1pBA@mail.gmail.com>
- In-Reply-To
- <CACsJy8DA4oCj3WPmJY6aA7Gq3Xx4xqZ2XxxiZUuR6TqgK=f6Ww@mail.gmail.com>
Duy Nguyen wrote:
> Nobody should ever parse these output > with scripts. The color can be generated from color.branch.*.
How do we implement color.branch.(current|local|remote|plain)? In the current code, we take a crude approach by hand-constructing argc, argv strings and passing it to cmd_for_each_ref(). There are no conditionals in the format syntax (and introducing one is probably not a good idea either): so, I'm guessing these configuration variables have to be read by for-each-ref?
> A bigger > problem is show_detached(), --[no-]merged, --with and --contains. We > need to move some of those code over to for-each-ref.
I saw that you fixed this.
> Another problem > is the new "branch -v" seems to less responsive than old "branch -v" > because (I think) of sorting, even if we don't need it.
Does your track-responsiveness patch fix this?
> I checked out > your branch, made some more updates and pushed out to my > for-each-ref-pretty again. Changes are:
*pants* Sorry, I'm finding it hard to keep up.