git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Resend PATCH] t3903 (stash): add failing test for ref of form ^{/message}

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Apr 16, 2013, 20:23 UTC
Message-ID
<CALkWK0=JdJGf7+yWvi2xkoruixK5G5mnQXm8pFhK60NQB2qX0Q@mail.gmail.com>
In-Reply-To
<7vmwsyl3mv.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I do not think anybody considered the approach to look at the commit
> object name and making sure it appears in the reflog that implements
> the stash. It sounds like a more robust check if done right.

Actually, if you think about it, there is really only one way to specify revisions in the stash's reflog: stash@*. Since these commits don't have to be reachable from any refs in the general case, all the other revision syntaxes are useless. So, I would argue that "${REV%@*}" is sufficient and correct*: anything beyond it is an unnecessary overhead.

However, the initial bug is still valid: show should not show something that pop cannot operate on.

* although I'd have been more comfortable if we had a neater way to specify that
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 12 in “t3903 (stash): add failing test for ref of form ^{/message}”
  1. t3903 (stash): add failing test for ref of form ^{/message}Ramkumar Ramachandra, Apr 16, 2013
  2. Junio C HamanoApr 16, 2013
  3. Ramkumar RamachandraApr 16, 2013
  4. Junio C HamanoApr 16, 2013
  5. Brandon CaseyApr 16, 2013
  6. Junio C HamanoApr 16, 2013
  7. Brandon CaseyApr 16, 2013
  8. Ramkumar RamachandraApr 16, 2013
  9. Ramkumar RamachandraApr 16, 2013
  10. Brandon CaseyApr 16, 2013
  11. Ramkumar RamachandraApr 17, 2013
  12. Junio C HamanoApr 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.