From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Tue, 16 Apr 2013 20:23:21 GMT
Subject: Re: [Resend PATCH] t3903 (stash): add failing test for ref of form ^{/message}
Message-ID: <CALkWK0=JdJGf7+yWvi2xkoruixK5G5mnQXm8pFhK60NQB2qX0Q@mail.gmail.com>
In-Reply-To: <7vmwsyl3mv.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> I do not think anybody considered the approach to look at the commit
> object name and making sure it appears in the reflog that implements
> the stash. It sounds like a more robust check if done right.

Actually, if you think about it, there is really only one way to
specify revisions in the stash's reflog: stash@*.  Since these
commits don't have to be reachable from any refs in the general case,
all the other revision syntaxes are useless.  So, I would argue that
"${REV%@*}" is sufficient and correct*: anything beyond it is an
unnecessary overhead.

However, the initial bug is still valid:  show should not show
something that pop cannot operate on.

* although I'd have been more comfortable if we had a neater way to specify that