Re: [Resend PATCH] t3903 (stash): add failing test for ref of form ^{/message}

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2013, 21:06 UTC
Message-ID: <7vobdejic0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0=JdJGf7+yWvi2xkoruixK5G5mnQXm8pFhK60NQB2qX0Q@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>> I do not think anybody considered the approach to look at the commit
>> object name and making sure it appears in the reflog that implements
>> the stash. It sounds like a more robust check if done right.
>
> Actually, if you think about it, there is really only one way to
> specify revisions in the stash's reflog: stash@*.
> ...
> * although I'd have been more comfortable if we had a neater way to specify that

Yup. "git stash pop +4", without a must-be-it token "stash" or mandatory "@{}" frill would have been much nicer.