Re: [PATCH 3/4] pack-objects: do not print usage when repacking

From: Antoine Pelisse <apelisse@gmail.com>
Date: Aug 8, 2013, 06:40 UTC
Message-ID: <CALWbr2yQBK9D3HJ2k9xPryKL=TFh_u7V2K5qOZJQw=J=qYXs+g@mail.gmail.com>
In-Reply-To: <1375884049-14961-4-git-send-email-stefanbeller@googlemail.com>

On Wed, Aug 7, 2013 at 4:00 PM, Stefan Beller <stefanbeller@googlemail.com> wrote:

Show 17 quoted lines

> ---
>  builtin/pack-objects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index 1742ea1..0bd8f3b 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -2585,7 +2585,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
>                 base_name = argv[0];
>                 argc--;
>         }
> -       if (pack_to_stdout != !base_name || argc)
> +       if (!(repack_flags & REPACK_IN_PROGRESS) && (pack_to_stdout != !base_name || argc))
>                 usage_with_options(pack_usage, pack_objects_options);
>
>         rp_av[rp_ac++] = "pack-objects";

Hello Stefan, I'm not sure I understand that and why it's needed, would you mind explain it to me ? (and/or maybe add it to the commit message)

Thanks,