git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Rewriting git-repack.sh in C

From
Duy Nguyen <pclouds@gmail.com>
Date
Aug 3, 2013, 10:03 UTC
Message-ID
<CACsJy8A-xo97MC-vBmqCrvvSDMWKd_MxnRrTBSeSqcQ1HifzJA@mail.gmail.com>
In-Reply-To
<20130803063325.GJ19369@paksenarrion.iveqy.com>
On Sat, Aug 3, 2013 at 1:33 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:
Show 11 quoted lines
> On Fri, Aug 02, 2013 at 09:10:59PM +0700, Duy Nguyen wrote:
>> > So my question is, how you'd generally approach rewriting a
>> > shell script in C.
>>
>> Start a new process via start_command/run_command interface. It's
>> safer to retain the process boundary at this stage. You can try to
>> integrate further later.
>
> Is it really the right approach to just replace sh with C? IMHO forking
> and wait for the result should not be done if it can be avoided. It just
> adds overhead.

Agreed. As I said in another post, I misread this as rewriting git-rebase.sh, which is a lot more complicated.

> Of course you can argue that just replace sh with C is a good first step
> towards to actually do the command in "full C". Altough I'm afraid that
> that will get such low priority that it won't be done.

One of the reasons I started porting git-repack.sh since 2011 and never finished it.

-- 
Duy
Previous: Fredrik GustafssonNext: Stefan Beller
Message 5 of 17 in “Rewriting git-repack.sh in C”
  1. Stefan BellerAug 2, 2013
  2. Duy NguyenAug 2, 2013
  3. Duy NguyenAug 2, 2013
  4. Fredrik GustafssonAug 3, 2013
  5. Duy NguyenAug 3, 2013
  6. 0/4 Re: Rewriting git-repack.sh in CStefan Beller, Aug 7, 2013
  7. 1/4 Build in git-repackStefan Beller, Aug 7, 2013
  8. Matthieu MoyAug 7, 2013
  9. Junio C HamanoAug 7, 2013
  10. Stefan BellerAug 7, 2013
  11. Duy NguyenAug 8, 2013
  12. 2/4 backup_file dummy functionStefan Beller, Aug 7, 2013
  13. Duy NguyenAug 8, 2013
  14. 3/4 pack-objects: do not print usage when repackingStefan Beller, Aug 7, 2013
  15. Antoine PelisseAug 8, 2013
  16. 4/4 repack: add unpack-unreachableStefan Beller, Aug 7, 2013
  17. Matthieu MoyAug 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.