Re: Gitweb 1.7.5 and Textconv Configuration
- From
Al Haraka <alharaka@gmail.com>
- Date
- Jul 2, 2011, 11:14 UTC
- Message-ID
- <CALWDD1woB0ytL6T-DwD92f824dnpz0mek=SYgz5jwqR0efnkpw@mail.gmail.com>
- In-Reply-To
- <20110702104437.GA10538@sigill.intra.peff.net>
On Sat, Jul 2, 2011 at 1:44 PM, Jeff King <peff@peff.net> wrote:
Show 9 quoted lines
> On Sat, Jul 02, 2011 at 06:43:13AM -0400, Jeff King wrote: > >> The default gitweb configuration doesn't allow textconv (or external >> diff) for security reasons; it would mean repo owners could execute >> arbitrary commands as the gitweb user. >> >> If that's OK for your site, you can probably enable it with: >> >> push @diff_opts, '--allow-textconv';
Just tried it.
$ more ~/repos/gitweb_config.perl # where is the git binary? $GIT = "/home/dreamhost_account/opt/bin/git"; # where are our git project repositories? $projectroot = $ENV{'GIT_PROJECT_ROOT'}; # what do we call our projects in the gitweb UI? $home_link_str = "~"; # where are the files we need for gitweb to display? @stylesheets = ("gitweb.css"); $logo = "git-logo.png"; $favicon = "/favicon.png"; # what do we call this site? $site_name = "my personal git repos"; # Enable textconv push @diff_opts, '--textconv';
Reloaded the webpage; still does *not* show text diffs. Any way to debug what is going wrong?
> Oops, this option is just called "--textconv". I got it confused with > the flag in the code, which is ALLOW_TEXTCONV.
No worries. You are steering my in the right direction, typos or not.
> -Peff >
-- Alexander J. Stein Cell: +974 70013750 Email: alharaka@gmail.com Skype: alexander.j.stein