Re: Gitweb 1.7.5 and Textconv Configuration

From: Jeff King <peff@peff.net>
Date: Jul 2, 2011, 10:43 UTC
Message-ID: <20110702104313.GA10245@sigill.intra.peff.net>
In-Reply-To: <CALWDD1x-_rEx+c9bpAgVk-hvnGz1bt0mbJoDkSjZkbe=gLscUg@mail.gmail.com>

On Sat, Jul 02, 2011 at 12:50:12PM +0300, Al Haraka wrote:

Show 7 quoted lines

> So, I tried different variations of this, specifically for repos.
> Now, I have tried it globally as that was tedious and it was not
> working anyway. That works some of the time if I try commands over the
> console (git log  -p for quick testing), but never in Gitweb.  It
> continues to only say they are differing binary files.  Does Gitweb
> 1.7.5 support the use of this?  Is there something special I must do?
> Below is my current config:

The default gitweb configuration doesn't allow textconv (or external diff) for security reasons; it would mean repo owners could execute arbitrary commands as the gitweb user.

If that's OK for your site, you can probably enable it with:

  push @diff_opts, '--allow-textconv';

I don't know that anybody has tested that, though. It will use textconv _everywhere_ in gitweb, including the "format-patch" invocation for showing raw patches of commits. It might make sense in the long run for gitweb to have another variable like @diff_opts that is used for human-readable output (e.g., the HTML output, but not anything you might import to a tool).

-Peff