Re: [PATCH] statinfo.h: move DTYPE defines from dir.h

From: Alejandro Sedeño <asedeno@google.com>
Date: Jun 3, 2023, 03:02 UTC
Message-ID: <CALVMLfK4zD4ifgtQLfXBKFJH43hfLevmvVdsZ-ydKCt8kuPfqw@mail.gmail.com>
In-Reply-To: <xmqqilc571hf.fsf@gitster.g>

Sorry for the dupes; resending as plain-text as per list requirements.

On Fri, Jun 2, 2023 at 9:56 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

>
> "Alejandro R Sedeño" <asedeno@google.com> writes:
>
> > …
> > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> > Signed-off-by: Alejandro R Sedeño <asedeno@google.com>

They are both me; it's my way of sticking with my historical personal address and still attaching my work address for work reasons.

Show 6 quoted lines

>
> This is a bit unusual; do you want to publish both names (I am
> assuming that they are the same single person)?
>
> I thought somebody in the earlier discussion identified the topic
> that was problematic by bisecting.  It is a shame to lose that.

I identified it earlier, by inspection because the machine I build on is slow and this was easy to track down.

Show 9 quoted lines

> Perhaps it is a good idea to rephrase the beginning of the proposed
> commit log message to mention that, like
>
>     592fc5b3 (dir.h: move DTYPE defines from cache.h, 2023-04-22)
>     moved DTYPE macros from cache.h to dir.h, but are still used
>     by cache.h to implement ce_to_dtype(); but cache.h cannot
>     include dir.h because ...
>
> or something?

Happy to rephrase.

-Alejandro