Re: [PATCH] statinfo.h: move DTYPE defines from dir.h

From: Elijah Newren <newren@gmail.com>
Date: Jun 3, 2023, 01:47 UTC
Message-ID: <CABPp-BEH46_daydTZpt0YLXLDYEOOeBobuht3hUgJvucSyUKMA@mail.gmail.com>
In-Reply-To: <20230602192700.1548636-1-asedeno@google.com>

On Fri, Jun 2, 2023 at 12:27 PM Alejandro R Sedeño <asedeno@google.com> wrote:

Show 6 quoted lines

>
> From: Alejandro R. Sedeño <asedeno@mit.edu>
>
> These definitions are used in cache.h, which can't include dir.h
> without causing name-hash.c to have two definitions of
> `struct dir_entry`.

...are _currently_ used in cache.h (your commit message is fine, just pointing it out for below...)

> Both dir.h and cache.h include statinfo.h, and this seems a reasonable
> place for these definitions.
>
> This change fixes a broken build issue on old SunOS.

Maintainer note for Junio: en/header-split-cache-h-part-3 moves the inline functions in cache.h that use the DT_* defines, but that series should both textually and semantically merge cleanly with this change. (Just noting this for your peace of mind.)

After en/header-split-cache-h-part-3 merges down, I might opt for a different fix (I'm still mulling it over), but that other fix isn't possible until cache.h is split up more. Alejandro's fix is the cleanest interim solution I can think of.

Reviewed-by: Elijah Newren <newren@gmail.com>