Re: What's cooking in git.git (May 2013, #05; Mon, 20)
- From
Johan Herland <johan@herland.net>
- Date
- May 21, 2013, 01:16 UTC
- Message-ID
- <CALKQrgcmmaqAt-oVtFeem_xvqsjehacVoVJ2bYOyfKWTUzV0AA@mail.gmail.com>
- In-Reply-To
- <7v38thrxwo.fsf@alter.siamese.dyndns.org>
On Tue, May 21, 2013 at 2:15 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> * jh/shorten-refname (2013-05-07) 4 commits > - t1514: refname shortening is done after dereferencing symbolic refs > - shorten_unambiguous_ref(): Fix shortening refs/remotes/origin/HEAD to origin > - t1514: Demonstrate failure to correctly shorten "refs/remotes/origin/HEAD" > - t1514: Add tests of shortening refnames in strict/loose mode > > When remotes/origin/HEAD is not a symbolic ref, "rev-parse > --abbrev-ref remotes/origin/HEAD" ought to show "origin", not > "origin/HEAD", which is fixed with this series (if it is a symbolic > ref that points at remotes/origin/something, then it should show > "origin/something" and it already does). > > I think this is being rerolled using strbuf_expand().
Actually, that was not on my TODO. Sure, my other series ([PATCHv2 00/10] Prepare for alternative remote-tracking branch location) builds on top of this one, and changes a lot of the same code, but I considered jh/shorten-refname a good set of changes in its own right, and I didn't want it to be held up by the much longer (and probably much longer-running) series.
The strbuf_expand refactoring is nice, but not really necessary until we start using multi-wildcard patterns.
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net