git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2013, #05; Mon, 20)

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 23, 2013, 10:07 UTC
Message-ID
<519DEA50.4030407@drmicha.warpmail.net>
In-Reply-To
<7vy5b7j7kc.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 22.05.2013 18:36:
Show 24 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>>> * mg/more-textconv (2013-05-10) 7 commits
>>>  - grep: honor --textconv for the case rev:path
>>>  - grep: allow to use textconv filters
>>>  - t7008: demonstrate behavior of grep with textconv
>>>  - cat-file: do not die on --textconv without textconv filters
>>>  - show: honor --textconv for blobs
>>>  - diff_opt: track whether flags have been set explicitly
>>>  - t4030: demonstrate behavior of show with textconv
>>>
>>>  I think this is ready for 'next'; not that it matters during the
>>>  prerelease feature freeze.
>>
>> Oh, I'm sorry, I thought we were still in discussions about the default
>> mechanism (config or attributes) and the implementation (tacking context
>> onto each object)? Therefore, I didn't hurry to polish and follow up
>> over my vacation. I'm not sure I had smoothed out all minor things
>> (honor/obey and such) when the object struct size issue came up. I'll
>> check today or tomorrow. (Freeze, yes, but we don't want too many next
>> rewrites, and one is coming soon...)
> 
> I thought this was fine as-is, but we can kick it back to 'pu' and
> replace it with a reroll after 1.8.3 if that is necessary.

Didn't you have concerns about storing the context in the object struct? I can't quite judge how much of an issue this can be for fsck and such. I don't want to increase the memory footprint unnecessarily, of course.

Other than that, the mechanism was still up for discussion (separate "show" attribute or a config) given that the default behavior for showing blobs is not to change.

Michael
Previous: Junio C HamanoNext: Junio C Hamano
Message 16 of 19 in “What's cooking in git.git (May 2013, #05; Mon, 20)”
  1. Junio C HamanoMay 21, 2013
  2. Felipe ContrerasMay 21, 2013
  3. Johan HerlandMay 21, 2013
  4. Junio C HamanoMay 21, 2013
  5. Johan HerlandMay 22, 2013
  6. Junio C HamanoJul 1, 2013
  7. Johan HerlandJul 2, 2013
  8. Thomas RastMay 21, 2013
  9. Junio C HamanoMay 21, 2013
  10. Jeff KingMay 29, 2013
  11. activate color.ui by default (Re: What's cooking in git.git (May 2013, #05; Mon, 20))Matthieu Moy, May 21, 2013
  12. Junio C HamanoMay 21, 2013
  13. Michael J GruberMay 22, 2013
  14. Michael J GruberMay 22, 2013
  15. Junio C HamanoMay 22, 2013
  16. Michael J GruberMay 23, 2013
  17. Junio C HamanoMay 23, 2013
  18. Michael J GruberMay 23, 2013
  19. Junio C HamanoMay 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.