git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2013, #05; Mon, 20)

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 23, 2013, 15:31 UTC
Message-ID
<519E366A.5040504@drmicha.warpmail.net>
In-Reply-To
<7vr4gxhi8y.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 23.05.2013 16:40:
Show 37 quoted lines
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> Didn't you have concerns about storing the context in the object struct?
>> I can't quite judge how much of an issue this can be for fsck and such.
>> I don't want to increase the memory footprint unnecessarily, of course.
> 
> Yes. I thought I had a weather-balloon patch to fsck to use its own
> so that we have something to fall back on if it turns out to be a
> problem (and also so that anybody can see how big the difference is),
> but I highly suspect that any user of object-array other than what
> you are changing in the series wants to use the slim variant, which
> suggests that the information does not belong there.
> 
>> Other than that, the mechanism was still up for discussion (separate
>> "show" attribute or a config) given that the default behavior for
>> showing blobs is not to change.
> 
> My understanding was that the series as-is (not the implementation
> but the external interface) makes us honor what the user tells us
> better, without changing the behaviour for people who don't instruct
> us to do anything differently, so I thought it was a good place to
> stop at.
> 
> The 'show attribute or config' discussion would/should involve the
> possibility of flipping the default, no?  After all, I was getting
> the impression, especially from the "config", that this was "If we
> had known better when we introduced textconv, we would have defined
> it to apply in any situation where you would want a textual form of
> a blob, not limited to diff" kind of thing.
> 
> That is a much longer term thing and my impression was that it can
> built later on top of the series (once its implementation settles).
> 
> So, yes, thanks for pointing out these two points. The bloat in the
> object array element I do care today, the feature and the interface
> I do not think we have to worry about them today to hold the series
> back.

Well, if we decide "showing blobs with textconv is fundamentally different from showing diffs with textconv" then "--textconv" should not apply any textconv filters on blobs unless the user has specified them using a separate attribute (different from "diff").

Therefore, I hesitate introducing the behavior of the current series. For me, it would introduce something of a "mixed beast".

I wouldn't hesitate introducing "textconv on by default for blobs the same as for diffs", but that would change existing behavior and the opposition is strong, for a good reason :)

So, since that one isn't possible, I'm leaning towards the other extreme: treat the blob and diff case completely separately in the sense that different attributes are used. Then, even with "--textconv" there wouldn't be any blob filtering (show/grep) unless the user specified so using an attribute different from "diff".

I'd rather try out the latter before having the "mixed beast" trickle down too much, even both its change in behavior and the one from the attribute version do not show up in daily use until you specify "--textconv" explicitly.

Michael
Previous: Junio C HamanoNext: Junio C Hamano
Message 18 of 19 in “What's cooking in git.git (May 2013, #05; Mon, 20)”
  1. Junio C HamanoMay 21, 2013
  2. Felipe ContrerasMay 21, 2013
  3. Johan HerlandMay 21, 2013
  4. Junio C HamanoMay 21, 2013
  5. Johan HerlandMay 22, 2013
  6. Junio C HamanoJul 1, 2013
  7. Johan HerlandJul 2, 2013
  8. Thomas RastMay 21, 2013
  9. Junio C HamanoMay 21, 2013
  10. Jeff KingMay 29, 2013
  11. activate color.ui by default (Re: What's cooking in git.git (May 2013, #05; Mon, 20))Matthieu Moy, May 21, 2013
  12. Junio C HamanoMay 21, 2013
  13. Michael J GruberMay 22, 2013
  14. Michael J GruberMay 22, 2013
  15. Junio C HamanoMay 22, 2013
  16. Michael J GruberMay 23, 2013
  17. Junio C HamanoMay 23, 2013
  18. Michael J GruberMay 23, 2013
  19. Junio C HamanoMay 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.