git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] odb/source-loose: fix failing existence checks caused by stale cache

From
Kristofer Karlsson <krka@spotify.com>
Date
Nov 4, 2026, 12:57 UTC
Message-ID
<CAL71e4ONN4OQUZ2S==0TRWqZgA8ogT0smRL3Rk46voTm+0Tihw@mail.gmail.com>
In-Reply-To
<20261104-pks-odb-loose-stale-cache-v1-0-a00d5cdb5e7d@pks.im>
On Wed, 4 Nov 2026 at 13:17, Patrick Steinhardt <ps@pks.im> wrote:
Show 14 quoted lines
>
> Hi,
>
> this small patch series fixes the bug reported in [1].
>
> In summary, when git-merge(1) writes merged blobs it may be unable to
> read them back because the loose object cache does not get updated.
> Consequently, we may think that the blobs do not exist locally, and thus
> in a promisor remote we may perform a backfill fetch. But as the remote
> doesn't know those objects we'll fail.
>
> Thanks!
>
> Patrick

The fix looks good to me, and I verified that the test fails without it. My own local fix is logically equivalent, which is a good sign, though perhaps that biased my review.

Thanks, Kristofer

Previous: Junio C HamanoNext: Derrick Stolee
Message 5 of 7 in “odb/source-loose: fix failing existence checks caused by stale cache”
  1. 0/2 odb/source-loose: fix failing existence checks caused by stale cachePatrick Steinhardt, Nov 4, 2026
  2. 1/2 odb/source-loose: extract logic to retrieve subdirectory bitmapPatrick Steinhardt, Nov 4, 2026
  3. 2/2 odb/source-loose: fix existence checks for newly written objectsPatrick Steinhardt, Nov 4, 2026
  4. Junio C HamanoNov 4, 2026
  5. Kristofer KarlssonNov 4, 2026
  6. Derrick StoleeNov 4, 2026
  7. Junio C HamanoNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.