Re: [PATCH 0/2] odb/source-loose: fix failing existence checks caused by stale cache

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 4, 2026, 16:27 UTC
Message-ID: <55e14977-dfc2-4acc-bc71-a91915fa251f@gmail.com>
In-Reply-To: <CAL71e4ONN4OQUZ2S==0TRWqZgA8ogT0smRL3Rk46voTm+0Tihw@mail.gmail.com>

On 11/4/2026 7:57 AM, Kristofer Karlsson wrote:

Show 19 quoted lines

> On Wed, 4 Nov 2026 at 13:17, Patrick Steinhardt <ps@pks.im> wrote:
>>
>> Hi,
>>
>> this small patch series fixes the bug reported in [1].
>>
>> In summary, when git-merge(1) writes merged blobs it may be unable to
>> read them back because the loose object cache does not get updated.
>> Consequently, we may think that the blobs do not exist locally, and thus
>> in a promisor remote we may perform a backfill fetch. But as the remote
>> doesn't know those objects we'll fail.
>>
>> Thanks!
>>
>> Patrick
> 
> The fix looks good to me, and I verified that the test fails
> without it. My own local fix is logically equivalent,
> which is a good sign, though perhaps that biased my review.

I also think the fix looks good. (I haven't verified it locally like Kristofer did, but the test is good.)

Thanks, -Stolee