From: Kristofer Karlsson <krka@spotify.com>
Date: Wed, 04 Nov 2026 12:57:52 GMT
Subject: Re: [PATCH 0/2] odb/source-loose: fix failing existence checks caused by stale cache
Message-ID: <CAL71e4ONN4OQUZ2S==0TRWqZgA8ogT0smRL3Rk46voTm+0Tihw@mail.gmail.com>
In-Reply-To: <20261104-pks-odb-loose-stale-cache-v1-0-a00d5cdb5e7d@pks.im>

On Wed, 4 Nov 2026 at 13:17, Patrick Steinhardt <ps@pks.im> wrote:
>
> Hi,
>
> this small patch series fixes the bug reported in [1].
>
> In summary, when git-merge(1) writes merged blobs it may be unable to
> read them back because the loose object cache does not get updated.
> Consequently, we may think that the blobs do not exist locally, and thus
> in a promisor remote we may perform a backfill fetch. But as the remote
> doesn't know those objects we'll fail.
>
> Thanks!
>
> Patrick

The fix looks good to me, and I verified that the test fails
without it. My own local fix is logically equivalent,
which is a good sign, though perhaps that biased my review.

Thanks,
Kristofer