Re: What's cooking in git.git (Dec 2025, #03)
- From
Emily Shaffer <nasamuffin@google.com>
- Date
- Dec 16, 2025, 17:49 UTC
- Message-ID
- <CAJoAoZk8AYmJHkFc58LGqn9yengsAd+5iTN-WuFtzBnews7EyA@mail.gmail.com>
- In-Reply-To
- <87v7i6g13j.fsf@collabora.com>
On Tue, Dec 16, 2025 at 2:42 AM Adrian Ratiu <adrian.ratiu@collabora.com> wrote:
Show 38 quoted lines
> > On Tue, 16 Dec 2025, Patrick Steinhardt <ps@pks.im> wrote: > > On Tue, Dec 16, 2025 at 10:59:56AM +0900, Junio C Hamano wrote: > >> Adrian Ratiu <adrian.ratiu@collabora.com> writes: > >> > >> > On Fri, 12 Dec 2025, Junio C Hamano <gitster@pobox.com> wrote: > >> >> * ar/run-command-hook (2025-12-04) 11 commits > >> >> ... > >> >> Use hook API to replace ad-hoc invocation of hook scripts with the > >> >> run_command() API. > >> >> > >> >> Will merge to 'next'? > >> >> source: <20251204141535.1986263-1-adrian.ratiu@collabora.com> > >> > > >> > I think this can be merged to next, since the latest iteration has been > >> > sitting for a few weeks with no more feedback and all tests are green. > >> > >> "tests being green" tells us that with the current coverage we > >> didn't see any regression but not more than that. Especially, it > >> does not say anything about the quality of new code (and test) and > >> if it is in good shape to build on top. > >> > >> It also is very hard to tell from "no more feedback" if there is no > >> room for further improvements, or people are simply disinterested in > >> the topic and are not tempted to spend their brain cycles to help > >> improve the topic. > >> > >> If there is no more comments, I'll try to see if I can block some > >> time to read the topic over myself with a pair of fresh eyes before > >> deciding. > > > > Thanks for the ping, I've now did another pass through v4 of this patch > > series. It looked mostly good except for one question I had. Depending > > on the answer I think this should be ready to go. > > I'll give Junio some more days in case he wants to take a look again at > the series, then send one last re-roll fixing your nits/question and > also addressing Junio's feedback, if there is any.
FWIW, I also expect Josh Steadmon to find time to take a look at this series soon, but he has been busy with personal side of things for the last few days. It's not that there's disinterest from our side, more that there is a lot going on :)
- Emily
> > Thanks!