git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Dec 2025, #03)

From
Aaron Plattner <aplattner@nvidia.com>
Date
Dec 17, 2025, 05:20 UTC
Message-ID
<9a318697-4bf5-4ac9-ab9f-f9851da7c54f@nvidia.com>
In-Reply-To
<xmqqecot3dm1.fsf@gitster.g>
On 12/16/25 9:02 PM, Junio C Hamano wrote:
Show 43 quoted lines
> Aaron Plattner <aplattner@nvidia.com> writes:
> 
>> On 12/12/25 2:26 AM, Junio C Hamano wrote:
>>> * ap/packfile-promisor-object-optim (2025-12-08) 2 commits
>>>    - packfile: skip hash checks in add_promisor_object()
>>>    - object: apply skip_hash and discard_tree optimizations to unknown blobs too
>>>
>>>    The code path that enumerates promisor objects have been optimized
>>>    to skip pointlessly parsing blob objects.
>>>
>>>    Comments?
>>>    source: <20251209014900.402637-1-aplattner@nvidia.com>
>> Jeff King said v2 of the patch looked good to him but recommended
>> splitting it into two changes. I don't know if he wanted to review v3 or
>> if he was okay with it based on his comments on v2. The only differences
>> in v3 are the commit count and descriptions.
> 
> v3 did not have links back to previous iterations, and
> 
> https://lore.kernel.org/git/?q=s%3A%22improve+--exclude-promisor-objects+performance%22
> 
> does not even show v1 or v2 (understandable if the topic was
> retitled, which is not a bad thing, but makes it harder to find the
> previous discussions in a case like this).  So as far as whoever
> wrote the entry in the "What's cooking" report you quoted was
> concerned, what [*] showed
> 
>   * https://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/
> 
> was everything known about the topic, which unfortunately had no
> supporting comments.
> 
> Is this
> 
>    https://lore.kernel.org/git/20251206002014.2066644-1-aplattner@nvidia.com/
> 
> which I found in
> 
>    https://lore.kernel.org/git/?q=f%3Aaplattner%40nvidia.com
> 
> the v2 discussion?  We are lucky that you are not as prolific as
> some contributors, for whom an author-name search would have found
> way too many messages ;-)

I'm sorry, I should have looked more closely at the format of other v(n>1) messages on the list and noticed the links to the previous discussions. In retrospect, that should have been an obvious requirement...

For completeness, here's all of the discussion:

v1: https://lore.kernel.org/git/4bd18399-26b3-44cd-93a7-8d2d32bef709@nvidia.com/T/ v2: https://lore.kernel.org/git/20251206002014.2066644-1-aplattner@nvidia.com/T/ v3: https://lore.kernel.org/git/20251209014900.402637-1-aplattner@nvidia.com/T/

Show 8 quoted lines
> I can see that the end result of applying the v3 patches match what
> was in v2, and v3 separates along the lines Peff suggested in his
> 
>    https://lore.kernel.org/git/20251208202812.GC216526@coredump.intra.peff.net/
> 
> so that's an endorsement enough, I guess ;-).
> 
> Let's mark the topic for 'next', then.  Thanks.
Thank you, I appreciate it!
-- Aaron
Previous: Junio C HamanoNext: Jeff King
Message 11 of 16 in “What's cooking in git.git (Dec 2025, #03)”
  1. Junio C HamanoDec 12, 2025
  2. Adrian RatiuDec 13, 2025
  3. Junio C HamanoDec 16, 2025
  4. Patrick SteinhardtDec 16, 2025
  5. Adrian RatiuDec 16, 2025
  6. Emily ShafferDec 16, 2025
  7. Junio C HamanoDec 17, 2025
  8. René ScharfeDec 13, 2025
  9. Aaron PlattnerDec 17, 2025
  10. Junio C HamanoDec 17, 2025
  11. Aaron PlattnerDec 17, 2025
  12. Jeff KingDec 17, 2025
  13. Junio C HamanoDec 17, 2025
  14. Aaron PlattnerDec 17, 2025
  15. Junio C HamanoDec 18, 2025
  16. Patrick SteinhardtDec 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.