Re: [PATCH] buitin_config: return postitive status in get_value
- From
- Nikolay Vladimirov <nikolay@vladimiroff.com>
- Date
- Jul 28, 2012, 13:18 UTC
- Message-ID
- <CAJg5NvdAq_zEx2phVGS4EiUfqMtFJA2Bo=y1d3FJyWXtzMwCTw@mail.gmail.com>
- In-Reply-To
- <CACsJy8BUU13H1tRfTtUme_7u0Jf0upca31U-VNhXva_0R2MLoQ@mail.gmail.com>
On 28 July 2012 15:59, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
Show 8 quoted lines
> I'm curious. Why is -1 (or 255) wrong? It was introduced in the first > version of get_value in 4ddba79 (git-config-set: add more options - > 2005-11-20). Back then it returned -1 when there's regex compile error > to distinguish with 0 and 1 (but git-config-set.txt in the same commit > did not get update about exit code). Maybe we should update document > instead of the code. > -- > Duy
That sounds great. But the behavior now seems kind of strange, or maybe I'm missing something: # git config foobar; echo $? error: key does not contain a section: foobar 255
# git config foobar.info; echo $? 1
git version 1.7.11.2
I would generally expect the both to behave the same way.