Re: [PATCH] buitin_config: return postitive status in get_value
- From
Jeff King <peff@peff.net>
- Date
- Jul 29, 2012, 21:41 UTC
- Message-ID
- <20120729214117.GB3071@sigill.intra.peff.net>
- In-Reply-To
- <7v4noqwb6e.fsf@alter.siamese.dyndns.org>
On Sun, Jul 29, 2012 at 01:43:21PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> > But if we really want to follow that "documented" subset of possible > > conditions, I agree that your version to return "1" in this case, > > together with a change to initialize "ret" to "7" and document it as > > "all other errors (ret=7), would make more sense. Other conditions > > that have been added since that partial enumeration of the exit code > > was done are regexp errors, which I think will get -1 from the same > > function. > > IOW, something like this. > > Documentation/git-config.txt | 18 ++++++++++-------- > builtin/config.c | 8 ++++++-- > 2 files changed, 16 insertions(+), 10 deletions(-)
This looks right to me. Even if we are missing an error case, it is certainly going in the right direction.
-Peff