git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] buitin_config: return postitive status in get_value

From
Jeff King <peff@peff.net>
Date
Jul 29, 2012, 21:41 UTC
Message-ID
<20120729214117.GB3071@sigill.intra.peff.net>
In-Reply-To
<7v4noqwb6e.fsf@alter.siamese.dyndns.org>
On Sun, Jul 29, 2012 at 01:43:21PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> > But if we really want to follow that "documented" subset of possible
> > conditions, I agree that your version to return "1" in this case,
> > together with a change to initialize "ret" to "7" and document it as
> > "all other errors (ret=7), would make more sense.  Other conditions
> > that have been added since that partial enumeration of the exit code
> > was done are regexp errors, which I think will get -1 from the same
> > function.
> 
> IOW, something like this.
> 
>  Documentation/git-config.txt | 18 ++++++++++--------
>  builtin/config.c             |  8 ++++++--
>  2 files changed, 16 insertions(+), 10 deletions(-)

This looks right to me. Even if we are missing an error case, it is certainly going in the right direction.

-Peff
Previous: Junio C HamanoNext: Nguyen Thai Ngoc Duy
Message 7 of 10 in “buitin_config: return postitive status in get_value”
  1. buitin_config: return postitive status in get_valueNikolai Vladimirov, Jul 28, 2012
  2. Nguyen Thai Ngoc DuyJul 28, 2012
  3. Nikolay VladimirovJul 28, 2012
  4. Nguyen Thai Ngoc DuyJul 28, 2012
  5. Junio C HamanoJul 29, 2012
  6. Junio C HamanoJul 29, 2012
  7. Jeff KingJul 29, 2012
  8. Nguyen Thai Ngoc DuyJul 30, 2012
  9. Junio C HamanoJul 30, 2012
  10. Jeff KingJul 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.