Re: [PATCH] buitin_config: return postitive status in get_value

From: Jeff King <peff@peff.net>
Date: Jul 29, 2012, 21:39 UTC
Message-ID: <20120729213928.GA3071@sigill.intra.peff.net>
In-Reply-To: <7vipd7vzql.fsf@alter.siamese.dyndns.org>

On Sat, Jul 28, 2012 at 11:38:10PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > Then the following patch may be better because it leaves other cases
> > untouched (I'm not saying that we should or should not do it though)
> 
> I personally think that the documentation unnecessarily exposes the
> useless value assignment of the exit codes (the use of different
> exit codes was done merely to aid debugging the git-config command
> itself) by describing the then-current set of conditions, and should
> be reduced to say "0 for success, non-zero for any error".

We use ret=5 in the test suite to say "unset this variable, but it's OK if it wasn't set in the first place" but still fail on error. The only other one I can imagine that would be useful is "you tried to get a variable but it did not exist, and there was no other error". Which is probably what ret=1 is attempting to do, though it also encompasses syntactically bogus keys.

-Peff