Re: [PATCH 11/11] sha1_file: convert write_sha1_file to object_id

From: Patryk Obara <patryk.obara@gmail.com>
Date: Jan 21, 2018, 16:26 UTC
Message-ID: <CAJfL8+SPCvCLMkXxjHrVkeHXt3t14Dj2x5nde7S17mcRomKB5g@mail.gmail.com>
In-Reply-To: <20180120204456.GB8965@genre.crustytoothpaste.net>

On 20 January 2018 at 21:44, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 15 quoted lines

> On Thu, Jan 18, 2018 at 03:51:03PM +0100, Patryk Obara wrote:
>> diff --git a/sha1_file.c b/sha1_file.c
>> index 88b960316c..b7baf69041 100644
>> --- a/sha1_file.c
>> +++ b/sha1_file.c
>> @@ -1420,8 +1420,8 @@ void *read_object_with_reference(const unsigned char *sha1,
>>  }
>>
>>  static void write_sha1_file_prepare(const void *buf, unsigned long len,
>> -                                    const char *type, unsigned char *sha1,
>> -                                    char *hdr, int *hdrlen)
>> +                                 const char *type, struct object_id *oid,
>> +                                 char *hdr, int *hdrlen)
>
> It looks like the indentation has changed here.  Was that intentional?

Yes. After every commit, I am running clang-format on lines, that I
touch to verify formatting and
decide if I want to include formatting fixes or not. In this case,
function parameters were
aligned using spaces only (which is arguably hard to see in the mail)
- now they are aligned to first
parameter (at least in my editor and in gitk :)).

-- 
| ← Ceci n'est pas une pipe
Patryk Obara